[Bug 31609] TestLauncher says a required DLL is missing, but the test runs fine without TestLauncher

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=31609

--- Comment #6 from François Gouget <fgouget at codeweavers.com> ---
Created attachment 61157
  --> https://bugs.winehq.org/attachment.cgi?id=61157
Dummy patch to run the vcomp:vcomp test

The new new plan is to _not_ get rid of TestLauncher because a more careful
analysis showed that TestLauncher and WineTest have quite different
requirements such that merging the two does not really make sense (imho).

Furthermore this issue is no longer present in the TestBot because the vcomp
test dynamically loads vcomp.dll.

Paradoxically WineTest still has the issue because it parses the name of the
test executable, infers that it's testing vcomp.dll, and then checks for the
presence of that dll. And apparently the code in WineTest is still not good
enough to properly detect the presence of vcomp.dll so that WineTest.exe does
not run vcomp_test.exe. So as is, merging TestLauncher with WineTest would make
things worse!

See also:
https://www.winehq.org/pipermail/wine-devel/2017-September/119052.html


Note that not all VMs have vcomp.dll. The attached patch can be used on the
TestBot to verify that it runs the test when appropriate and to figure out
which VMs have vcomp.dll. Based on the current results the 32 bit dll is
present on w2000pro, wxppro, w2003std, wvistau64*, w2008s64, w8, w864 and the
64 bit one is present on wvistau64, w2008s64 and w864.

Note that some online resources seem to imply that vcomp.dll is present in the
Visual C++ 2005 redistributable (and VC++ 2005 was indeed installed on all the
VMs that have vcomp.dll except w2008s64 (though maybe it was installed and it
was not written down)). Some VMs seem to have other versions such as
vcomp90.dll but not vcomp.dll.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.