[Bug 44965] Microsoft Visual Studio 2013, 2017: compiler output (cl.exe) is no longer properly shown in output pane (missing file location, subsequent error messages)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=44965

--- Comment #6 from Matthieu Brucher <matthieu.brucher at gmail.com> ---
With the help of my boss, we figured out that the issue is
LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE and LOAD_LIBRARY_AS_IMAGE_RESOURCE 
management (commits e55101715cee244ef1857d9a975f87a9d6e3fac0,
e1d8c176efdd04fb2a0f99426e1ad9962589b9ec and
8d82ab4ae7e3375e3e100f2bfaa0b6bf1466877d).
The issue arise because all the localized strings from cl come from clui.dll
(error messages, and even the main banner). It seems that with these patches,
the strings that cl tried to load are always empty, pointing to an issue in the
way these two flags are used.
To reproduce the error, it is as easy as installing VS2017 (community edition
for instance) and compile a file with just #error.
The current wine would show:

test.cpp
test.cpp(2) : fatal error C1189:

When the error message should be:
Microsoft (R) C/C++ Optimizing Compiler Version 18.00.31101 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

test.cpp
test.cpp(2) : fatal error C1189: #error :

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.