[Bug 45078] UFOHD2 crashes inside devenum

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=45078

Zebediah Figura <z.figura12 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.figura12 at gmail.com

--- Comment #3 from Zebediah Figura <z.figura12 at gmail.com> ---
It crashes because the program tries to pass a NULL ppv to
IMoniker_BindToObject():

0156:trace:devenum:DEVENUM_IMediaCatMoniker_BindToObject (0x15ccb8)->((nil),
(nil), {56a86895-0ad4-11ce-b03a-0020af0ba770}, (nil))
wine: Unhandled page fault on write access to 0x00000000 at address 0x7d4069a5
(thread 0156), starting debugger...

Judging by the disassembly, my best guess is someone screwed up their pointer
indirection:

  404849:    8b 4c 24 28             mov    ecx, [esp+28h]
  40484d:    8b 44 24 0c             mov    eax, [esp+0Ch]
  404851:    8b 10                   mov    edx, [eax]
  404853:    8b 52 20                mov    edx, [edx+20h]
  404856:    51                      push    ecx
  404857:    68 00 0f 55 00          push    dword 00550F00h
  40485c:    6a 00                   push    dword 00000000h
  40485e:    6a 00                   push    dword 00000000h
  404860:    50                      push    eax
  404861:    ff d2                   call    edx

suggesting someone coded "moniker::BindToObject(NULL, NULL, &IID_IBaseFilter,
(void **)obj".

I've sent a patch.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.