[Bug 44287] New: Possible access to unintended variable in "wine/dlls/ gdi32/freetype.c" line 2349
wine-bugs at winehq.org
wine-bugs at winehq.org
Thu Jan 4 03:36:33 CST 2018
https://bugs.winehq.org/show_bug.cgi?id=44287
Bug ID: 44287
Summary: Possible access to unintended variable in
"wine/dlls/gdi32/freetype.c" line 2349
Product: Wine
Version: unspecified
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: gdi32
Assignee: wine-bugs at winehq.org
Reporter: petrum at gmail.com
Distribution: ---
While experimenting with a CodeSonar plugin we develop, we noticed a
potential bug in file "wine/dlls/gdi32/freetype.c" line 2349 function
map_font_family
Family *family = find_family_from_any_name(repl);
if (family != NULL)
{
Family *new_family = HeapAlloc(GetProcessHeap(), 0, sizeof(*new_family));
if (new_family != NULL)
{
TRACE("mapping %s to %s\n", debugstr_w(repl), debugstr_w(orig));
new_family->FamilyName = strdupW(orig);
new_family->EnglishName = NULL;
list_init(&new_family->faces);
new_family->replacement = &family->faces; //HERE
list_add_tail(&font_list, &new_family->entry);
return TRUE;
}
}
Shouldn't new_family be used (instead of family) at the mentioned position?
Thanks,
Petru Florin Mihancea
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
More information about the wine-bugs
mailing list