[Bug 44310] WritePrivateProfileString doesn't check for flush errors

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=44310

Fabian Maurer <dark.shadow4 at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |dark.shadow4 at web.de
     Ever confirmed|0                           |1

--- Comment #3 from Fabian Maurer <dark.shadow4 at web.de> ---
Good catch, this is indeed problematic.
You probably want to add a test case (should be easy enough) and then sent it
to the mailing list once code-freeze is over.

While you're at it, there are more places where PROFILE_FlushFile is called. Do
these show the same erroneous behavior? Like in "WritePrivateProfileSectionW",
"WritePrivateProfileStructW"


Site not, I don't like chaining two methods that have side effects with "&&"
like that. I'd probably prefer
------
ret = PROFILE_SetString( section, entry, string, FALSE);
ret &= PROFILE_FlushFile();
------
or
------
ret = PROFILE_SetString( section, entry, string, FALSE);
if(ret)
    ret = PROFILE_FlushFile();
------
But I don't know about the coding style, just wanted to note.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.