[Bug 44310] WritePrivateProfileString doesn't check for flush errors

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=44310

--- Comment #14 from Alexandre Julliard <julliard at winehq.org> ---
(In reply to Fabian Maurer from comment #13)
> > It probably doesn't matter in this case, but note that there's nothing that
> > says that a boolean must be TRUE, any non-zero value would do. So printing
> > it is not necessarily useless.
> > 
> > For the same reason, your &= trick is not a good idea.
> 
> Is that "&=" a real concern at this point? Because I think it makes it
> easier to read while it's pretty easy to check that it's safe.

It may look easier on the surface, but using an incorrect construct is actually
more confusing for people reading the code.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.