[Bug 45199] Many applications and games fail to start/ crash after compiling wine with gcc 8.1.0 and -O2 (GOT/ PIC register load code now emitted at function entry, missing hotpatch signatures)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=45199

--- Comment #36 from Anastasius Focht <focht at gmx.net> ---
Hello Zebediah,

--- quote ---
Isn't the "mov %edi,%edi" prefix present on all functions in Windows?

Is there a reason we shouldn't just add this attribute unconditionally to
__stdcall/__cdecl?
--- quote ---

definitely on all __stdcall exports, not sure for __cdecl.

Yes, in hindsight it would have been a lot less painful/effort by not using the
"on demand" approach.

It all started with Stefan's Steam Overlay/Xfire work here:

https://www.winehq.org/pipermail/wine-devel/2009-October/079198.html
https://gcc.gnu.org/ml/gcc-cvs/2009-10/msg00319.html

https://source.winehq.org/git/wine.git/shortlog/refs/tags/wine-1.1.32?pg=4

--- snip ---
$ grep -r DECLSPEC_HOTPATCH dlls | wc -l
177
--- snip ---

These would need to be removed afterwards.

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.