[Bug 40742] cmd.exe: buffer overflow while parsing qualifiers

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=40742

Jason Edmeades <us at edmeades.me.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |us at edmeades.me.uk

--- Comment #4 from Jason Edmeades <us at edmeades.me.uk> ---
Brian, I appreciate this is an ancient defect but I am just working through
some of the cmd related ones. In principle, your patch would be fine, but I am
struggling slightly in that it doesnt crash any longer on current wine (for
me).

Looking at the wcmd_parse routine, quals gets set when parsing finds a '/'
character and contains data until end of line (a null), a space or another '/'.

The problem I have is your script doesnt contain any long data. The longest
qualifier I can see is 116 characters, and that's way under the limit - hence
I'm thinking something else might be going on here

Are you still able to reproduce? I'd love to be able to get more info (a +cmd
trace for example).

It leaves me in a sticky position - I'd happily have supported your proposed
patch as its only using a tiny amount more memory for a static buffer, however 
 I really cannot see that what you say triggers it would have!

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.