[Bug 45292] SuperTux 0.5.1 does not start (application bug)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=45292

Anastasius Focht <focht at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |focht at gmx.net
            Summary|SuperTux 0.5.1 does not     |SuperTux 0.5.1 does not
                   |start                       |start (application bug)
                URL|http://www.supertux.org/dow |https://github.com/SuperTux
                   |nload.html                  |/supertux/releases/download
                   |                            |/v0.5.1/SuperTux-v0.5.1-win
                   |                            |32.msi

--- Comment #2 from Anastasius Focht <focht at gmx.net> ---
Hello folks,

confirming.

Boost documentation for reference:

https://www.boost.org/doc/libs/1_61_0/libs/filesystem/doc/reference.html#create_directory

--- quote ---
bool create_directory(const path& p);
bool create_directory(const path& p, system::error_code& ec);

    Effects: Establishes the postcondition by attempting to create the
directory p resolves to, as if by ISO/IEC 9945 mkdir() with a second argument
of S_IRWXU|S_IRWXG|S_IRWXO. Creation failure because p resolves to an existing
directory shall not be treated as an error.

    Postcondition: is_directory(p)

    Returns: true if a new directory was created, otherwise false.

    Throws: As specified in Error reporting.
--- quote ---

Boost source:

https://github.com/boostorg/filesystem/blob/6f31d4e07c3c2cd290f39e85385398cd633d062f/src/operations.cpp#L1030

Git blame in SuperTux code shows this:

https://github.com/SuperTux/supertux/commit/ebae41b10354bfd71d91de1dd503d9001c056f69
("Support unicode usernames on Windows ")

Gotta love the granularity of this changeset.
You don't don't push commits that change multiple completely unrelated things
but rather prefer small, atomic commits.

They should also use an exception handler here to ignore exceptions thrown by
boost's create_directory if the requested directory exists or where path p
exists but it wasn't possible for the user to write to the parent directory.
Only re-throw on hard-error.

The Github page for the project also hosts the released binaries, no need for
for some questionable MEGA site link

https://github.com/SuperTux/supertux/releases

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.