[Bug 31784] Add support for VM snapshots

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=31784

François Gouget <fgouget at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from François Gouget <fgouget at codeweavers.com> ---
We now have support for multiple snapshots per VM.

commit 035ad3d5ab6ec66d91d10961bf834db5f0c6d7eb
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Mar 1 11:02:25 2018 +0100

    testbot: Allow multiple VMs to share access to a hypervisor domain.

    This makes it possible to define two or more VM instances that have the
    same VirtURI and VirtDomain values and differ only in their IdleSnapshot
    field. This can be used to perform tests on multiple configurations of a
    given Windows version, such as testing different locales, etc.

    However a hypervisor domain only has one current snapshot. So the
    TestBot can only use one of the VM instances that depend on this
    hypervisor domain at any time.

    An important consequence is that $VM->Status does not necessarily
    matches the state of the hypervisor domain. So $VM->Status == off does
    not mean that the TestBot is free to revert the domain to that VM
    snapshot. The status of the other VMs using the same hypervisor domain
    much be checked first. This is handled by some extra _CanScheduleOnVM()
    calls.

    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

commit 070b78e17a9a0408eb17f01f96860fcd1d846923
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Feb 28 02:01:03 2018 +0100

    testbot: Avoid race conditions between LibvirtTool monitor and other tools.

    If another tool was trying to connect to the VM's TestAgent server when
    'LibvirtTool monitor' powered off the VM, that other tool may mark the
    VM as offline right after it has been put back online. So wait for other
    tools to time out after monitor powers off a VM.

    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

commit cad513a33e9c0f32af427ac2d2caf63f23f168b0
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Feb 28 01:55:41 2018 +0100

    testbot: Replace poweroff with checkoff in the Engine's Cleanup().

    checkoff verifies that the hypervisor domain state matches that of the
    current VM instance before powering it off.
    If the state does not match then the VM is just marked off.

    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

commit ab35ecaf100d649a8b182e1bfba22c1b754cb8bc
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Feb 28 01:54:45 2018 +0100

    testbot: Check the current snapshot in LibvirtTool monitor.

    If the snapshot does not match when the hypervisor domain becomes
    accessible again, then don't try to power if off and just mark the
    VM instance as off.

    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

commit 98ec6ba6d7aa219201a2defda745af4febfbeef0
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Feb 28 01:54:29 2018 +0100

    testbot: Check the current snapshot in LibvirtTool checkidle.

    If the snapshot does not match then the current VM instance is not
    actually using the hypervisor domain so mark it off.

    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.