[Bug 43783] Cannot activate Office2013 (KMS nor MAK)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=43783

--- Comment #23 from Hans Leidekker <hans at meelstraat.net> ---
(In reply to Luiz Angelo Daros De Luca from comment #22)
> Yes, it did work! Thanks a lot! I needed to unset env vars.
> 
> Normally setting it as null is enough for other softwares to ignore it. I
> guess wine could also follow that behavior.
> 
> I just checked the code and it check for a special case of invalid proxy
> (when scheme is not http). Wouldn't it be better to simply check for a valid
> one? We could try to parse "$http_proxy" or "http://$http_proxy" as an URL
> (using WinHttpCrackUrl?) . If it fails, ignore it. I guess it would even
> simplify the code.

Right, I have already submitted a patch in that direction.

> In a quick look, it seems that proxy support is very limited. It does not
> support https, and it looks like it also does not support authentication.
> Would it help to create new bugs for each of those missing features?

Sure.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.