[Bug 43570] Bravura Easy Computer Sync 1.5 crashes on startup

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=43570

Louis Lenders <xerox.xerox2000x at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |b14d8f9f11856c1b1f192bf773e
                   |                            |b864cba5ad78b
                 CC|                            |xerox.xerox2000x at gmail.com

--- Comment #3 from Louis Lenders <xerox.xerox2000x at gmail.com> ---
(In reply to Anastasius Focht from comment #2)
> Hello folks
> 
> confirming.

> You need to add shell32 resources for:
> 
> * IDI_SHELL_RICH_TEXT (2)
> * IDI_SHELL_EXE (3)
> 
> The app will no longer crash and display some "Waiting for cable connection"
> dialog.
> 

> 
> Regards

Starts fine in current git. 

Alex added lots of icons, i.e. commit b14d8f9f11856c1b1f192bf773eb864cba5ad78b

 git show b14d8f9f11856c1b1f192bf773eb864cba5ad78b
commit b14d8f9f11856c1b1f192bf773eb864cba5ad78b
Author: Alex Henrie <alexhenrie24 at gmail.com>
Date:   Tue Aug 14 22:09:57 2018 -0600

    shell32: Add document icon.

    Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc
index 992c70f..b6cae77 100644
--- a/dlls/shell32/shell32.rc
+++ b/dlls/shell32/shell32.rc
@@ -422,6 +422,9 @@ END
 /* @makedep: document.ico */
 IDI_SHELL_FILE ICON document.ico

+/* @makedep: document.ico */
+IDI_SHELL_DOCUMENT ICON document.ico
+
 /* @makedep: folder.ico */
 IDI_SHELL_FOLDER ICON folder.ico

diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h
index cf43d4a..9c46d5f 100644
--- a/dlls/shell32/shresdef.h
+++ b/dlls/shell32/shresdef.h
@@ -170,6 +170,7 @@
 #define IDD_TREEVIEW           0x3741

 #define IDI_SHELL_FILE               1
+#define IDI_SHELL_DOCUMENT           2
 #define IDI_SHELL_FOLDER             4
 #define IDI_SHELL_FOLDER_OPEN        5
 #define IDI_SHELL_5_12_FLOPPY        6

 sha1sum ~/Downloads/EasySyncSetup.exe 
470b36058e11615e736b30cecabc4a89053767ed 
/home/louis/Downloads/EasySyncSetup.exe

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.