[Bug 28140] Theatre of War 3: Korea demo 1.2.0 crashes on startup ( hook engine can't cope with GOT/PIC register load code at API entry, needs DECLSPEC_HOTPATCH for kernel32.SizeofResource)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=28140

Anastasius Focht <focht at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|ea7186348f48a749ab28ecc405f |002a19599be273b9f947425a820
                   |b56601c56e4f8               |897816317c378
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #17 from Anastasius Focht <focht at gmx.net> ---
Hello folks,

this is fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/002a19599be273b9f947425a820897816317c378
("kernel32: Add DECLSPEC_HOTPATCH to SizeofResource().").

Thanks Gijs

--- snip ---
$ winedbg --gdb 8

...

Wine-gdb> x/10i 0x7b47a105

   0x7b47a105 <SizeofResource>:    jmp    0x7ffc094f
   0x7b47a10a <SizeofResource>:    call   0x7b42f068 <__x86.get_pc_thunk.ax>
   0x7b47a10f <SizeofResource+5>:    add    $0x1e8ef1,%eax
   0x7b47a114 <SizeofResource+10>:    cmpl   $0x0,0xc(%ebp)
   0x7b47a118 <SizeofResource+14>:    jne    0x7b47a121 <SizeofResource+23>
   0x7b47a11a <SizeofResource+16>:    mov    $0x0,%eax
   0x7b47a11f <SizeofResource+21>:    jmp    0x7b47a127 <SizeofResource+29>
   0x7b47a121 <SizeofResource+23>:    mov    0xc(%ebp),%eax
   0x7b47a124 <SizeofResource+26>:    mov    0x4(%eax),%eax
   0x7b47a127 <SizeofResource+29>:    pop    %ebp

Wine-gdb> x/10i 0x7ffc094f

   0x7ffc094f:    popl   -0x8(%esp)
   0x7ffc0953:    push   $0xd4bd60
   0x7ffc0958:    sub    $0x4,%esp
   0x7ffc095b:    jmp    0xa79864
   0x7ffc0960:    mov    %edi,%edi
   0x7ffc0962:    push   %ebp
   0x7ffc0963:    mov    %esp,%ebp
   0x7ffc0965:    jmp    0x7b47a10a <SizeofResource>
   0x7ffc096a:    lods   %ds:(%esi),%eax
   0x7ffc096b:    fiadds (%edi)
--- snip ---

$ du -sh *
952M    setup-1.bin
692M    setup-2.bin
1.9M    setup.exe

$ sha1sum *
679e0c4e3bfd7c367ff1002fbe995378b8686a14  setup-1.bin
042f43f8c5ca5720b1664e35f56f725313d7cd04  setup-2.bin
73128ca5fa7a14e0e6a1466e85857d5b9a45f52c  setup.exe

$ wine --version
wine-4.5-83-g33c35baa67

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.