[Bug 38924] HeapSize(GetProcessHeap(), 0, GlobalLock(hGlobal)) must succeed [wxWidgets samples, Tapps2, DirMaster]

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38924

--- Comment #13 from Damjan Jovanovic <damjan.jov at gmail.com> ---
Created attachment 65866
  --> https://bugs.winehq.org/attachment.cgi?id=65866
[PATCH] kernel32: implement Windows NT style GMEM_MOVEABLE/LMEM_MOVEABLE memory

This was my patch sent to wine-devel at .

While it works, it was rejected. IRC discussion:

Nov 20 19:37:46 <dacha> can i please have some feedback on why
https://source.winehq.org/patches/data/173892 was rejected? am i not allowed to
add wine-specific exports to kernelbase.dll?
Nov 20 19:40:59 <nsivov>        dacha, there should be a good reason to add a
new one
Nov 20 20:00:19 <nsivov>        dacha, if I was doing it, I'd rather move all
related functions to kernelbase
Nov 20 20:00:34 <nsivov>        this patch seems to do more that one thing
though
Nov 20 20:01:18 <dacha> nsivov: thank you
Nov 20 20:01:41 <zf>    I think that everything that belongs in kernelbase is
already there
Nov 20 20:01:49 <zf>    kernelbase only has exports for some global/local
functions
Nov 20 20:02:21 <dacha> so then move everything back to kernel32 and redirect
from kernelbase?
Nov 20 20:02:27 <dacha> ;)
Nov 20 20:02:27 <nsivov>        no
Nov 20 20:03:15 <nsivov>        ideal solution is to fix it without additional
exports and without moving more that should be
Nov 20 20:03:37 <cdavis5x>      Windows somehow makes this work, so it should
be possible

(we couldn't understand/agree on how Windows did it)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.