[Bug 46833] Install of iTunes 12.9.3.3 fails:err:msi: ITERATE_Actions Execution halted, action L"SxsInstallCA" returned 1603

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=46833

--- Comment #14 from Louis Lenders <xerox.xerox2000x at gmail.com> ---
(In reply to Fabian Maurer from comment #13)
> Okay, so after some confusion and some red herrings, I bisected this to
> 
> commit e4ca5dbec056c977bffce31bd7901aaec884f199
> Author: Huw Davies <huw at codeweavers.com>
> Date:   Tue Feb 26 11:06:25 2019 +0000
> 
>     server: Add new pipe servers to the end of the servers list.
> 
> 
> Can you confirm that reverting this commit helps? Because for me, that makes
> both installers work fine again.

Hi Fabian, that commit doesn`t revert cleanly for me in current git. So I
reverted it manually (see below). Anyway, the installer finishes fine for me
with  reverted patch. Thanks for the effort of regressiontest.


diff --git a/server/named_pipe.c b/server/named_pipe.c
index a6ec8ae06a..1e7667348e 100644
--- a/server/named_pipe.c
+++ b/server/named_pipe.c
@@ -1165,7 +1165,7 @@ static struct pipe_server *create_pipe_server( struct
named_pipe *pipe, unsigned
     server->pipe_end.server_pid = get_process_id( current->process );
     init_async_queue( &server->listen_q );

-    list_add_tail( &pipe->listeners, &server->entry );
+    list_add_head( &pipe->listeners, &server->entry );
     if (!(server->pipe_end.fd = alloc_pseudo_fd( &pipe_server_fd_ops,
&server->pipe_end.obj, options )))
     {
         release_object( server );

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.