[Bug 17205] MessageBoxes doesn't have the copy(Ctrl-C) feature

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=17205

Gabriel Ivăncescu <gabrielopcode at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gabrielopcode at gmail.com

--- Comment #18 from Gabriel Ivăncescu <gabrielopcode at gmail.com> ---
Created attachment 64606
  --> https://bugs.winehq.org/attachment.cgi?id=64606
Make the hook local to the Message Box's thread

I think the second patch in the series is wrong (the one that sets the hook).
It installs a global hook, and I doubt that's what we want. The problem is that
it can lead to random crashes in other applications in the same wineprefix.
This has been very hard to track down, because it happens randomly, but every
time it happened when a message box was created.

Mind you, this happens in *another* application in the same prefix. e.g. a
message box pops up in a text editor to ask you to confirm exiting without
saving, and this leads to a crash in an app in the background! (in the same
wineprefix).

Is there a reason the hook is global? If not, please update the second patch in
wine-staging by applying this attached patch on top of it.

After applying this patch I haven't got any random crashes for hours now, so
I'm 99% sure it was this global hook messing something up.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.