[Bug 48034] Better detect which Wine-related project a patch applies to
WineHQ Bugzilla
wine-bugs at winehq.org
Mon Nov 4 05:11:41 CST 2019
https://bugs.winehq.org/show_bug.cgi?id=48034
--- Comment #3 from François Gouget <fgouget at codeweavers.com> ---
Filenames like /Makefile.in are the reason behind $AmbiguousPathsRe.
If instead the TestBot checked the patch against multiple repositories it would
detect such a filename automatically since it would be present in multiple
repositories. So a patch that only changes /Makefile.in would look like it
could apply to multiple repositories and then what to do is a matter of
heuristics.
Random though: what about using 'git apply --check' on the server?
If the patch is applicable then we'd have positive proof that it is a Wine
patch.
But if it does not we would not know because it's a bad patch or because it's
not a Wine patch at all... unless we also test it against other Wine-related
repositories.
Also this would happen before the job is created so I'm not sure how the
TestBot would report that the patch is bad. Maybe send a Marvin email as usual
but not point to any job? We may still need something for
source.winehq.org/patches.
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
More information about the wine-bugs
mailing list