[Bug 48090] New: Add support for .com programs
WineHQ Bugzilla
wine-bugs at winehq.org
Wed Nov 13 08:13:27 CST 2019
https://bugs.winehq.org/show_bug.cgi?id=48090
Bug ID: 48090
Summary: Add support for .com programs
Product: Wine-Testbot
Version: unspecified
Hardware: x86
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: unknown
Assignee: wine-bugs at winehq.org
Reporter: fgouget at codeweavers.com
Distribution: ---
The TestBot assumes that if a patch touches a directory in programs, then it
must append .exe to the program's name.
But Wine could also get .com programs, see for instance chcp.com:
https://www.winehq.org/pipermail/wine-devel/2019-November/154371.html
And in fact we already have other programs with non-standard extensions, for
instance winhelp.exe16 and winoldap.mod16.
So if the program's directory already has an extension the TestBot should not
add one. Another option would be to use the MODULE setting in the directory's
Makefile.in file. But the TestBot server does not have access to the Wine
source. It would also make it harder to deal with patches adding test
directories and it would be quite ugly to have to read them every time anyway.
It would make it harder to deal with patches adding dlls/programs as it would
require parsing the patch to retrieve the MODULE value.
Another option may be to never add an extension, though then there's the risk
of getting collisions between the dll and program names, and maybe it impacts
other parts of the TestBot anyway.
_CreateTestInfo() in testbot/lib/WineTestBot/PatchUtils.pm needs to be patched
but there are impacts elsewhere. The WTBS (Wine TestBot test Suite) will also
need to be updated.
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
More information about the wine-bugs
mailing list