[Bug 39269] FX Interactive Webplayer fails to install, reporting 'File not found' (SHFileOperation FO_MOVE operation with wildcard source fails)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39269

--- Comment #11 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to Lorenzo Ferrillo from comment #10)
> Created attachment 66878 [details]
> patchset + test for wine 5.6
> 
> I post the initial version of the test here.
> 
> Zebediah to you thinki is bette rto post the test and the patch in spearate
> patches?

Generally the best situation is to put the test in a separate patch, and put it
first, with the appropriate todo_wines, so you can see exactly what was fixed.
If that's not possible, I don't think it particularly matters whether the test
is in the same patch or a separate patch after the fix.

> 
> Do you think that its' better to add the new  test in test_moves function
> instead fo adding my own function at the bottom? (I did this as the
> test_moves is huge)

I think either way is fine, probably. I would recommend getting rid of all of
those helper functions, though. init_shfo_tests() may be useful since it's
called multiple times, but here I think it makes the code harder to read.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.