[Bug 48941] Wine's implementation of IMalloc.DidAlloc relies on a spy mechanism, while Windows just calls "HeapValidate"

WineHQ Bugzilla wine-bugs at winehq.org
Thu Apr 16 10:50:00 CDT 2020


https://bugs.winehq.org/show_bug.cgi?id=48941

--- Comment #4 from Nikolay Sivov <bunglehead at gmail.com> ---
(In reply to Kyle_Katarn from comment #3)
> (In reply to Nikolay Sivov from comment #1)
> > It's true that what we have is incomplete, for example fSpyed is never set,
> > but how do you that Windows is using HeapValidate and when? Also please
> > attach source code for that test case.
> 
> Do you need more details ?

Question regarding HeapValidate() still stands. For use case, no, it's clear
what breaks - we simply don't return correct flags, with spy or without. Of
course there is not reason to do DidAlloc, or SHGetMalloc() in this code, it
should simply call CoTaskMemFree(), or ILFree/SHFree() which is the same thing.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list