[Bug 48941] Wine's implementation of IMalloc.DidAlloc relies on a spy mechanism, while Windows just calls "HeapValidate"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48941

--- Comment #7 from Nikolay Sivov <bunglehead at gmail.com> ---
(In reply to Kyle_Katarn from comment #5)
> Thanks !
> I opened a ticket on JCL side. Would you have a patch to propose to change
> the code according to your suggestions ?

I'm not going to patch it, no, and I don't know what was authors motivation
too. If it was a workaround for some garbage pointer passed in, that could
cause damage. Ideally callers should not pass invalid input, and if it's some
internal function, callers should be fixed, and function could then be
simplified.

> 
> Regarding Wine, do you imply that the fix in order to correctly handle such
> code (which runs perfectly in Windows) will not be investigated ? Or do you
> have a potential fix in Wine to suggest ?


Sure, it should be fixed in Wine too. I'll probably take a look.

> 
> this is blocking all apps using this JCL code section in Wine (+ potentially
> others). Thanks !

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.