[Bug 43030] LINE: Window border stays on top of other windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=43030

axzxc1236 <axzxc1236_wine_tracker at protonmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axzxc1236_wine_tracker at prot
                   |                            |onmail.com

--- Comment #33 from axzxc1236 <axzxc1236_wine_tracker at protonmail.com> ---
I saw comment #16 (thanks a lot! I couldn't never figure this out myself in 100
years) and decided to create a patch for myself, it does in fact removed black
border that was happening when clicking to other non-LINE window.

I use KDE Plasma and didn't see random blank window appearing when restoring
from iconify (is iconify a word?), also doesn't see border render incorrectly
again.
The issue #1 I am seeing is that some border didn't get cleared up when moving
LINE window downward, which can usually be cleared by moving LINE window again.
(I only ran the patched wine for like half an hour so needs more testing)

The patch below is tested with 6.0-rc1.
!!!You should compile/install wine patched with this to a separate location
that is not in $path because it was not tested enough!!!

--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -345,7 +345,9 @@ static unsigned long get_mwm_decorations( struct
x11drv_win_data *data,
  */
 static int get_window_attributes( struct x11drv_win_data *data,
XSetWindowAttributes *attr )
 {
-    attr->override_redirect = !data->managed;
+    //attr->override_redirect = !data->managed;
+    //patch for issue 43030..... only intended for LINE
+    attr->override_redirect = 0;
     attr->colormap          = data->whole_colormap ? data->whole_colormap :
default_colormap;
     attr->save_under        = ((GetClassLongW( data->hwnd, GCL_STYLE ) &
CS_SAVEBITS) != 0);
     attr->bit_gravity       = NorthWestGravity;

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.