[Bug 49590] Battle.net Agent.exe hang/crash

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49590

--- Comment #4 from Maciej Stanczew <maciej.stanczew+b at gmail.com> ---
Created attachment 67772
  --> https://bugs.winehq.org/attachment.cgi?id=67772
Logs non-staging

(In reply to i.Dark_Templar from comment #2)
> To me it happens almost soon after launching a game from Battle.net, for
> example Starcraft II. Each time message box is displayed, it brings
> Battle.net application's window to foreground.
It looks very similar to my case, probably it's the same issue.

(In reply to i.Dark_Templar from comment #3)
> I've looked a bit in this commit. In this commit winebuild-Fake_Dlls
> patchset is removed for wine-staging 5.12. Later a different implementation,
> patchset winebuild-pe_syscall_thunks, is added for wine-staging 5.13. I
> think it might be an issue in this patchset, and a regression in
> wine-staging 5.13 compared to wine-staging 5.11. But I might be wrong.
These were also my first suspicions, but they turned out to be false, or at
least incomplete.

I was able to reproduce the issue on plain Wine 5.13. Logs attached.
I have done further bisection of upstream commits, and got this as the commit
that introduces regression:

82cd85b07918a4437428497ffaf7f13286b83479 is the first bad commit
commit 82cd85b07918a4437428497ffaf7f13286b83479
Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Tue Jul 7 18:58:34 2020 -0500

    ntdll: Set the thread creation time in
NtQuerySystemInformation(SystemProcessInformation).

    Process Hacker displays this information.


With this commit reverted from Staging 5.13:
- I can use Battle.net App and launch games without any popups appearing about
Agent crashing;
- I can't reproduce the exception anymore by killing and manually launching
Agent.exe.

However, automatically spawned Agent still sometimes crashes -- I can see it
happening in process list, and by entries in 'Errors' directory.
It seems to happen most often when launching games: Agent will crash, new one
will spawn, and eventually one will "stick" and things will proceed. I don't
see any functional impact -- no popups and game hangs.
I didn't see any crashes in Staging 5.10. Unfortunately because of the time
between disabling Fake_Dlls and introduction of pe_syscall_thunks, there's no
way to do a bisect with launching games to trigger this crash.

After all the testing and reverting I'm starting to think there might be
multiple issues leading to Agent crashing. But the one this bug was initially
about seems to be related to 82cd85b07918a4437428497ffaf7f13286b83479.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.