[Bug 49590] Battle.net Agent.exe hang/crash

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49590

Paul Gofman <pgofman at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pgofman at codeweavers.com

--- Comment #5 from Paul Gofman <pgofman at codeweavers.com> ---
The blamed commit is misleading, I suggest removing it from Regression SHA1
field. Bisect showed that because it stopped working after that one, but the
crash present now is not related. As far as my testing goes so far, the
reintroduced syscall thunks patchset is also not at fault.

I could reproduce crashes in Agent.exe with the latest Staging and Starcraft.
It looks like some memory overwrite issue. WINEDEBUG=warn+heap shows tail
overwrites, and the crashes are always in ntdll heap allocation / free
functions, which clearly suggests that heap control data is smashed. Can you
try Staging without ntdll-Heap_Improvements patchset (staging/patchinstall.py
--all -W ntdll-Heap_Improvements). That was fixing the issue for me, would be
interesting to confirm if that is the same issue I am seeing.

It is not much likely that ntdll-Heap_Improvements is at fault per se, it just
introduces a different memory control structures layout which appears to be
more vulnerable.

It is yet to be verified if the memory smash is solely due to Agent code or
maybe imposed by something in Wine.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.