[Bug 49385] New: Wine builtin programs fail to display Wine version in 'About' dialog when using Wine-Staging specific 'hide Wine version from applications' feature

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49385

            Bug ID: 49385
           Summary: Wine builtin programs fail to display Wine version in
                    'About' dialog when using Wine-Staging specific 'hide
                    Wine version from applications' feature
           Product: Wine-staging
           Version: 5.10
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: wine-bugs at winehq.org
          Reporter: focht at gmx.net
                CC: leslie_alistair at hotmail.com, z.figura12 at gmail.com
      Distribution: ---

Hello folks,

a user reported a "glitch" in bug 49383 (which is a different issue). Failure
to display the Wine version with Wine's builtin file manager.

https://bugs.winehq.org/attachment.cgi?id=67445

I'm pretty sure he used Wine-Staging and the 'hide Wine version from
applications' feature for whatever reasons.

I don't mind if you resolve this report as 'WONTFIX' because that's the
side-effect of hiding Wine-specific 'ntdll.wine_get_build_id' export.

Still useful for documentation purpose/reference.

https://source.winehq.org/git/wine.git/blob/948a6a47b8dbd0ddd86cad04de03f0e4ba81b65d:/dlls/shell32/shell32_main.c#l910

--- snip ---
 907 /*************************************************************************
 908  * AboutDlgProc            (internal)
 909  */
 910 static INT_PTR CALLBACK AboutDlgProc( HWND hWnd, UINT msg, WPARAM wParam,
 911                                       LPARAM lParam )
 912 {
 913     HWND hWndCtl;
 914 
 915     TRACE("\n");
 916 
 917     switch(msg)
 918     {
 919     case WM_INITDIALOG:
 920         {
 921             ABOUT_INFO *info = (ABOUT_INFO *)lParam;
 922             WCHAR template[512], buffer[512], version[64];
 923             const char *(CDECL *wine_get_build_id)(void);
 924 
 925             if (info)
 926             {
 927                 wine_get_build_id = (void *)GetProcAddress(
GetModuleHandleA("ntdll.dll"),
 928                                                            
"wine_get_build_id");
 929                 SendDlgItemMessageW(hWnd, stc1,
STM_SETICON,(WPARAM)info->hIcon, 0);
 930                 GetWindowTextW( hWnd, template, ARRAY_SIZE(template) );
 931                 sprintfW( buffer, template, info->szApp );
 932                 SetWindowTextW( hWnd, buffer );
 933                 SetWindowTextW( GetDlgItem(hWnd, IDC_ABOUT_STATIC_TEXT1),
info->szApp );
 934                 SetWindowTextW( GetDlgItem(hWnd, IDC_ABOUT_STATIC_TEXT2),
info->szOtherStuff );
 935                 GetWindowTextW( GetDlgItem(hWnd, IDC_ABOUT_STATIC_TEXT3),
 936                                 template, ARRAY_SIZE(template) );
 937                 if (wine_get_build_id)
 938                 {
 939                     MultiByteToWideChar( CP_UTF8, 0, wine_get_build_id(),
-1, version, ARRAY_SIZE(version) );
 940                     sprintfW( buffer, template, version );
 941                     SetWindowTextW( GetDlgItem(hWnd,
IDC_ABOUT_STATIC_TEXT3), buffer );
 942                 }
 943                 hWndCtl = GetDlgItem(hWnd, IDC_ABOUT_LISTBOX);
 944                 SendMessageW( hWndCtl, WM_SETREDRAW, 0, 0 );
 945                 SendMessageW( hWndCtl, WM_SETFONT, (WPARAM)info->hFont, 0
);
 946                 add_authors( hWndCtl );
 947                 SendMessageW( hWndCtl, WM_SETREDRAW, 1, 0 );
 948             }
 949         }
 950         return 1;
--- snip ---

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.