[Bug 48732] How to Survive crashes on start (fullscreen mode)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48732

--- Comment #5 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to Gabriel Ivăncescu from comment #4)
> Created attachment 66627 [details]
> Test workaround
> 
> Does this patch help? It should avoid the call if the window has no owner to
> begin with.
> 
> The issue is that this shouldn't be needed, as there's nothing in the call,
> so I don't know if it's suitable for upstream, but that's up to Zeb.
> Personally I'm fine with it, if it helps.
> 
> I don't know if it's a game bug that can't handle a redundant call to
> SetParent for example, or if there's a deeper issue with Wine.
> 

That doesn't seem right, and I'd be surprised if it helps. If the window is
parentless it shouldn't result in any messages getting sent to the application.

> The refcount issue I mentioned earlier seems harmless. For some reason, it
> is caused by:
> 
>     if (filter->presenter)
>         IVMRImagePresenter9_Release(filter->presenter);
> 
> in quartz/vmr9.c vmr_destroy function, which decreases the refcount after it
> was already zero. However, this doesn't really seem to do anything, since on
> the filter side, it checks if (!refcount) and otherwise does nothing, so it
> seems harmless and likely not the culprit.

That doesn't seem right either; the allocator/presenter is a separate object
with its own refcount. Are you sure that's where the dereference is coming
from?

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.