[Bug 48732] How to Survive crashes on start (fullscreen mode)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48732

--- Comment #10 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to Gabriel Ivăncescu from comment #9)
> (In reply to Zebediah Figura from comment #8)
> > (In reply to Gabriel Ivăncescu from comment #6)
> > > Right, I was thinking the app does something weird like hook into SetParent.
> > > Or perhaps the call exposes a race condition of a deeper issue, which is a
> > > bigger concern. (this would just "hide" it)
> > 
> > That seems very unlikely, but if the patch really helps, I don't even know
> > what to think. I'd really like to figure out *why* the patch helps before
> > accepting it, honestly.
> > 
> 
> Maybe it's due to SetWindowLongPtr rather than SetParent itself. Possible
> causes I can think of that might be related:
> 
> * SetWindowLongPtr does a wineserver call.
> * It sends WM_STYLECHANGING message.
> * It calls a winex11 driver function, X11DRV_SetWindowStyle.
> 
> I'm speculating at this point, because I can't reproduce the crash either.
> But I suspect the last one. It probably has to do with a specific Window
> Manager or similar (perhaps that's why it also applies only to full-screen).

I don't see any of this as an explanation. Why would any of these cause a crash
in application code?

> 
> Regardless, should I send it to the mailing list for upstream inclusion?
> Since it does help with the crash.

I'm not particularly happy about accepting it without knowing why it helps,
given that it's not obviously a good idea otherwise.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.