[Bug 48838] New: Fails to compile due to wrong #ifdef

WineHQ Bugzilla wine-bugs at winehq.org
Sat Mar 28 10:28:59 CDT 2020


https://bugs.winehq.org/show_bug.cgi?id=48838

            Bug ID: 48838
           Summary: Fails to compile due to wrong #ifdef
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: wldap32
          Assignee: wine-bugs at winehq.org
          Reporter: harry+winehq at unheit.net
      Distribution: ---

Bug introduced in commit 364ac6787a39e2037f87ca7d728c949564c634b1.

dlls/wldap32/bind.c defines function sasl_interact, which uses TRACE. Function
is in #ifdef HAVE_LDAP_H but WINE_DEFAULT_DEBUG_CHANNEL is in #ifdef HAVE_LDAP.

So if HAVE_LDAP_H is defined but HAVE_LDAP isnt, compilation failes.

Fix:

diff --git a/dlls/wldap32/bind.c b/dlls/wldap32/bind.c
index 63d4208eef..46b866fd31 100644
--- a/dlls/wldap32/bind.c
+++ b/dlls/wldap32/bind.c
@@ -179,7 +179,7 @@ exit:
     return ret;
 }

-#ifdef HAVE_LDAP_H
+#ifdef HAVE_LDAP

 static int sasl_interact( LDAP *ld, unsigned flags, void *defaults, void
*interact )
 {
@@ -219,7 +219,7 @@ static int sasl_interact( LDAP *ld, unsigned flags, void
*defaults, void *intera
 #endif /* HAVE_SASL_SASL_H */
 }

-#endif /* HAVE_LDAP_H */
+#endif /* HAVE_LDAP */

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list