[Bug 25500] Megarace 3: in-game videos not working (videos require WMV1 codec)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=25500

Zebediah Figura <z.figura12 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.figura12 at gmail.com

--- Comment #11 from Zebediah Figura <z.figura12 at gmail.com> ---
Created attachment 68555
  --> https://bugs.winehq.org/attachment.cgi?id=68555
(hack?) reorder colors...

The game seems to accept any RGB format in its renderer, but blithely blits the
data into a D3DFMT_R5G6B5 d3d8 surface regardless of the actual connection
type. Presumably native outputs RGB16 before (or in lieu of) any other RGB
formats.

The attached patch fixes the video problems for me (although the video is still
green and purple, which is a separate bug that affects other applications as
well).

It's a little unfortunate, because I'm not sure that we really want to prefer
RGB16 to BGRx—not only because it could mean a double conversion for videoflip,
but also because it potentially loses some color depth. It's not a particularly
large concern as it's a non-default code path in several ways, but it also may
be difficult to notice regressions. It certainly deserves testing with native
WMV decoders, to confirm that they really prefer RGB16, and perhaps examination
of libav/gstreamer.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.