[Bug 50105] New Vegas Heap Replacer crashes with "Call from 0x7bc91c09 to unimplemented function d3dx9_38.dll.D3DXMatrixMultiply"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50105

Olivier F. R. Dierick <o.dierick at piezo-forte.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |o.dierick at piezo-forte.be

--- Comment #5 from Olivier F. R. Dierick <o.dierick at piezo-forte.be> ---
(In reply to Zebediah Figura from comment #4)
> Created attachment 68598 [details]
> ntdll: Use a dynamically allocated buffer in find_forwarded_export() if
> necessary.

Hello,

Isn't there an issue with unconditionally freeing mod_name?

When buffer is large enough the condition on line 616 will be false and
mod_name will still point to buffer.

I think lines 646 & 669 should read:

if (mod_name != buffer)
    RtlFreeHeap( GetProcessHeap(), 0, mod_name );

Regards.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.