[Bug 50163] New: Regression: Stack overflow in Mod Organizer 2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50163

            Bug ID: 50163
           Summary: Regression: Stack overflow in Mod Organizer 2
           Product: Wine
           Version: 5.22
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: wine-bugs at winehq.org
          Reporter: rtpublic1 at gmail.com
      Distribution: ---

Created attachment 68680
  --> https://bugs.winehq.org/attachment.cgi?id=68680
Patch reverting the bad commit on top of 5.22

Since commit df2b13fa77172953fed6e15c65fd6380b2d2f0d3, Mod Organizer 2
experiences a stack overflow during startup in the Python plugin (enabled by
default).

df2b13fa77172953fed6e15c65fd6380b2d2f0d3 is the first bad commit
commit df2b13fa77172953fed6e15c65fd6380b2d2f0d3
Author: Chip Davis <cdavis at codeweavers.com>
Date:   Wed Nov 18 17:26:33 2020 +0100

    msvcrt: Increment refcounts for all locale data in _get_current_locale().

    Signed-off-by: Chip Davis <cdavis at codeweavers.com>
    Signed-off-by: Piotr Caban <piotr at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

 dlls/msvcr90/tests/msvcr90.c | 52 ++++++++++++++++++++------------------------
 dlls/msvcrt/locale.c         | 19 +++++++++++++---
 2 files changed, 39 insertions(+), 32 deletions(-)

The previous commit (16598c2af6ddf0e32c5c72b9067cd2f40a470591) works.
Also, reverting the bad commit on top of 5.22 works. The reverting patch is
attached, just in case.

Installer download:
https://github.com/ModOrganizer2/modorganizer/releases/download/v2.3.2/Mod.Organizer-2.3.2.exe
$ md5sum Mod.Organizer-2.3.2.exe 
ca0b3a364bc5cac33299b14202e28620  Mod.Organizer-2.3.2.exe

The installer tries to download "Visual C++ 2015-2019 Redistributable (x64)"
and install it. Installation may or may not fail, I have not found any pattern
here. If installing fails, click Ignore to continue. It does not affect the
stack overflow either way.

After installing, start C:\\Modding\\MO2\\ModOrganizer.exe.

If you get asked to choose an "instance", select "Portable".

The first time, you may get a crash with some .NET exception. That is a
separate issue. Restart MO2, and it will ask you to disable the csharp plugin.
Do so to avoid that crash.

If you get a window asking to select a game, or asking, the stack overflow does
not appear and the issue is gone.

If you restart after the stack overflow, MO2 will ask to disable the python
plugin (say no) and whether  you wish to reinitialize the plugin (say yes to
cause the crash again).

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.