[Bug 49919] Regression: Logos Bible Software wineserver crash entering text in passage guide search field

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49919

--- Comment #9 from Daniel Ribeiro da Silva <ferion11 at hotmail.com> ---
(In reply to qsniyg from comment #8)
> (In reply to Daniel Ribeiro da Silva from comment #5)
> > # first bad commit: [d28c7938c704fe4dcfc8920db494a7175a46fe6b] dmstyle:
> > Return S_FALSE for IDirectMusicStyle8::GetMotif.
> > 
> > d28c7938c704fe4dcfc8920db494a7175a46fe6b is the first bad commit
> > commit d28c7938c704fe4dcfc8920db494a7175a46fe6b
> > Author: Myah Caron <qsniyg at protonmail.com>
> > Date:   Thu Sep 17 09:04:02 2020 +0000
> > 
> >     dmstyle: Return S_FALSE for IDirectMusicStyle8::GetMotif.
> >     
> >     Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49850
> >     Signed-off-by: Myah Caron <qsniyg at protonmail.com>
> >     Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
> >     Signed-off-by: Alexandre Julliard <julliard at winehq.org>
> > 
> >  dlls/dmstyle/style.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> At least from the log provided by m0rvj, I have literally no idea how this
> would break it, as IDirectMusicStyle8Impl_GetMotif isn't even called (it
> should show a fixme).
> 
> The only possible explanation I can think of is that there's some kind of
> issue with the debugstr_w thing, but I highly doubt it. Why would logos even
> use directmusic?
> 
> Considering m0rvj and Nick mentioned that the error occurs inconsistently,
> perhaps the bisect was incorrect?

I'm sorry, I didn't have updated the report on this subject, but I can
reproduce the bug consistently, and after applying the regression patch, the
bug is no longer present. The git bisect is correct.

LogosBible uses audio to reproduce the pronunciation in the original languages
​​of ancient texts, and other similar uses. Which isn't a serious issue if it
doesn't work for some time, but preventing the use of the "Passage Guide" is
something that must be solved.

I don't think that your game without sound, as you yourself reported, can be
considerably playable. And that you should look for a real implementation, that
really solves your problem, and propose only a patch that does this and not one
that do only part of it. Therefore, I believe that LogosBible would have
priority over this fix return value.
But if you have made progress on your side, and your game is playable with
sound, then I will look for an implementation or stub for this method.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.