[Bug 50035] Bugs in ntdll-Junction_Points staging patchset

WineHQ Bugzilla wine-bugs at winehq.org
Sun Oct 25 18:40:49 CDT 2020


https://bugs.winehq.org/show_bug.cgi?id=50035

--- Comment #6 from Erich E. Hoover <erich.e.hoover at gmail.com> ---
(In reply to Martin Storsjö from comment #4)
> ...
> Yeah, it seems to have been lost here:
> https://github.com/wine-staging/wine-staging/commit/
> 4ffe305c90f9e15141f2c1b10e86a15a5b9b7e3f

Huh, I must have made a mistake when I gave Zeb my updates.

> ...
> No, I'm taking a shortcut, by passing FALSE to the alloc parameter to the
> FILE_name_AtoW function - just like CopyFileA does:
> https://source.winehq.org/git/wine.git/blob/
> f6a5a3d03c1eb914444af96352ca54eec79d7e2c:/dlls/kernel32/path.c#l100
> ...
> AFAIK that should be ok here?

That's either new(ish) or I never noticed it before.  That's very convenient!

> ...
> But I actually need lstrcpynW, because info->path points to the full string
> ending with "dirname\*", while we just want the dirname. But the
> intermediate extra backslash isn't needed as it's included in
> info->path.Length.

Looks good, I'll merge these into my local copy and send Zeb an update.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list