[Bug 49852] Performance regression in "msvcrt: Use correct code page in _write when outputing to console."

WineHQ Bugzilla wine-bugs at winehq.org
Fri Sep 18 10:26:13 CDT 2020


https://bugs.winehq.org/show_bug.cgi?id=49852

Piotr Caban <piotr.caban at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |piotr.caban at gmail.com

--- Comment #5 from Piotr Caban <piotr.caban at gmail.com> ---
I've sent a patch that fixes console detection code in _write. It uses
VerifyConsoleIoHandle function that is slow. It speeds up the execution when
output is redirected to /dev/null and slows down when output goes to console.
In order to improve execution time VerifyConsoleIoHandle will need to be
improved.

Old code was faster but incorrect. I'm not sure if we should consider it as
regression taking into account we're on par with native speed.

Another workaround you can use:
wine64 ihateeh-x86_64.exe |cat &>/dev/null

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list