[Bug 39841] Double Commander context menus missing most entries

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39841

--- Comment #7 from Damjan Jovanovic <damjan.jov at gmail.com> ---
Comment 6, the lack of options in file menus, has the same cause as bug #24893,
which is now fixed. (Shellview menu IDs are large numbers, and Double Commander
wants them within the range 1-4093. Wine excluded them because they're > 4093,
but we now rebase them to lower values, and they fit.)

Comment 5, the "Error: Invalid parameter" when right-clicking on an empty
space, is the only remaining issue here. It's very easy to fix, it's just these
2 lines:

---snip---
    } else if (IsEqualIID(&IID_IContextMenu, riid)) {
        hr = BackgroundMenu_Constructor((IShellFolder*)iface, FALSE, riid,
ppv);
---snip---

that have to be added to ShellFolder2_CreateViewObject() in
dlls/shell32/shfldr_unixfs.c.

That's just for the filesystem though. It would be nice to also try implement
IID_IContextMenu in CreateViewObject() for other shell folders, like desktop,
recycle bin, etc.

Since only right-clicking the background is the problem now, I am changing the
summary to reflect.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.