[Bug 51922] HID joystick constant Force Feedback effect does not work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51922

--- Comment #16 from Rémi Bernon <rbernon at codeweavers.com> ---
(In reply to Ivo Ivanov from comment #14)
> The only problem I could still spot is that the damper condition effect is
> very weak in comparison to hidraw and Windows. Assetto Corsa Competizione
> uses such effect when the car is stand still.
> 

Could it be that the saturations and deadband values are scaled to 0-0x7fff,
although they are unsigned and should maybe use an 0-0xffff range?

Something like this maybe:

diff --git a/dlls/winebus.sys/hid.c b/dlls/winebus.sys/hid.c
index 8680f8a088c..32628f1f2fd 100644
--- a/dlls/winebus.sys/hid.c
+++ b/dlls/winebus.sys/hid.c
@@ -641,7 +641,7 @@ static BOOL hid_descriptor_add_set_condition(struct
unix_device *iface)
             USAGE(1, PID_USAGE_NEGATIVE_SATURATION),
             USAGE(1, PID_USAGE_DEAD_BAND),
             LOGICAL_MINIMUM(1, 0),
-            LOGICAL_MAXIMUM(2, 0x7fff),
+            LOGICAL_MAXIMUM(4, 0xffff),
             PHYSICAL_MINIMUM(1, 0),
             PHYSICAL_MAXIMUM(2, +10000),
             REPORT_SIZE(1, 16),

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.