[Bug 51790] MSI is no longer able to detect correct architecture for a custom action DLL

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51790

--- Comment #5 from Hans Leidekker <hans at meelstraat.net> ---
(In reply to Dmitry Timoshkov from comment #4)
> (In reply to Hans Leidekker from comment #3)
> > Created attachment 71245 [details]
> > patch
> > 
> > Does his patch help?
> 
> Thanks Hans. I can't at the moment test the affected intaller, but the code
> seems to include a reasonable subset of the GetBinaryTypeW implementation.
> Should it also handle STATUS_INVALID_IMAGE_WIN32/STATUS_INVALID_IMAGE_WIN64
> like GetBinaryTypeW does (however I don't see where those can be returned
> from)?

Good point. We could get STATUS_INVALID_IMAGE_WIN64 in case of an installer
trying to load a 64-bit DLL in a 32-bit prefix (see server/mapping.c). We
handle that case explicitly in dlls/msi/custom.c but I see it won't work if
get_binary_type() fails.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.