[Bug 52191] Null pointer dereference in MPEG3_StreamConvert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52191

Zebediah Figura <z.figura12 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.figura12 at gmail.com

--- Comment #2 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to Nikolay Sivov from comment #1)
> No, this looks accurate. The issue seems to be about having two functions
> variants, one in lfs_wrap.c and actual implementation in libmpg123.c. The
> wrapper does not check for null pointer, while implementation does.
> 
> It could a configuration issue, or a difference in win32 build. Maybe
> libmpg123 devs would be open to patching lfs_wrap.c accordingly.

mpg123 should probably be patched, but also, as the "real" implementation
shows, our code is buggy. I'm not sure we need the mpg123_feedseek() call at
all; I'll have to investigate further.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.