[Bug 52207] HICON leak in CopyImage causes TheBat! to crash after a while

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52207

--- Comment #5 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to jswinebz from comment #4)
> (btw, I'm assuming that passing in LR_COPYDELETEORG and LR_COPYFROMRESOURCE
> to the original call is nonsensical - according to docs LR_CFR should only
> be used on LR_SHARED icons, and those should *not* be passed to DestroyIcon
> at all so we should never see that. If anything, an attempt to do that
> should be caught and either generate its own kind of error or be bypassed
> and do nothing...)

It's a bit of a moot point, because LR_COPYDELETEORG only deletes the original
on success, whereas we also need to delete ours on failure. So that part will
have to be changed anyway.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.