[Bug 52250] windows.h WINE_NOWINSOCK check has been removed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52250

--- Comment #2 from Marcos Gutiérrez Batz <sacrom at gmail.com> ---
(In reply to Alexandre Julliard from comment #1)
> You could try defining _WINSOCKAPI_ instead.

Thanks Alexandre, good idea it makes sense, but it has two problems:

1) Defining WINE_NOWINSOCK is "selfdocumenting" while the _WINSOCKAPI_ is not
so obvious (this can easily be solved with a proper comment, though)

2) There are other libraries that check if this value is defined, in our case
we use libcurl and now we have other errors like:

 /sc/pub/curl_v7.51.0/include/curl/multi.h:155:40: error:
‘Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library’ has not been
declared

I guess this second problem can be solved undef'ing the _WINSOCKAPI_, but it
makes the solution quite complex to maintain.

While this small check doesn't have this issues and is neat.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.