[Bug 50586] NtQueryInformationFile returns STATUS_INVALID_INFO_CLASS on symlinks opened with FILE_OPEN_REPARSE_POINT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50586

--- Comment #21 from Erich E. Hoover <erich.e.hoover at gmail.com> ---
(In reply to Zebediah Figura from comment #20)
> (In reply to Erich E. Hoover from comment #19)
> > ...
> (Note also that we've already reported directory
> symlinks as FILE_ATTRIBUTE_REPARSE_POINT since forever, though we haven't
> implemented really any of the other behaviour surrounding that.)

Right, so I would say my first priority should be to fix this bug by making the
unix symlinks fully transparent again (ignore FILE_OPEN_REPARSE_POINT) since
that's been our baseline for some time.  If we run into some applications that
actually care then it would not be too much trouble to change and report them
"properly", so we could always re-evaluate at that point.

> > ...
> > But we
> > may be spending a lot of effort thinking about something that's not really a
> > big deal, do you know if we have any bugs reported for issues like this?
> 
> That's the real question, because honestly I don't, but I'm not sure I trust
> that. 

Yeah, I understand that feeling.  I think that we've found over the years of
updating these patches that reparse tag support is far more complicated than
otherwise would be expected.  However, I think that each time that we've opened
a new can of worms that we've made a lot of progress.  FILE_OPEN_REPARSE_POINT
may just be our most recent can, but I'm personally feeling like we're finally
coming to a place where we have all of our bases covered.

> ...
> I don't think I've seen any application choke on symlinks, however,
> cross-device or same-device, except for the occasional fixable bug in the
> wine-staging patches.

That's good to hear, it definitely feels like a fair number of the bugs have
been me doing something dumb rather than larger architectural issues.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.