[Bug 50677] New: uxtheme-GTK3_Theming broken, or is it?

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50677

            Bug ID: 50677
           Summary: uxtheme-GTK3_Theming broken, or is it?
           Product: Wine-staging
           Version: 5.20
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: wine-bugs at winehq.org
          Reporter: arek_koz at o2.pl
                CC: leslie_alistair at hotmail.com, z.figura12 at gmail.com
   Regression SHA1: 5b5a6de9b8dcc400dab62f4cc105f7108fda7517
      Distribution: ---

uxtheme-GTK3_Theming was removed from patchinstall.sh, since it probably did
not build / apply cleanly from 5.20 onwards. And it got `Disabled: true` in its
definition.

https://github.com/wine-staging/wine-staging/commit/5b5a6de9b8dcc400dab62f4cc105f7108fda7517#diff-5c82398d747fe60348afbbc2a5ddc1cd01ea96d600be66b9b828bc5064546de4

But it does apply cleanly (at least on newest 6.2):

git clone --depth=1 --branch=wine-6.2 git://source.winehq.org/git/wine.git
git clone --depth=1 --branch=v6.2 git://github.com/wine-staging/wine-staging
cd wine
git am ../wine-staging/patches/winecfg-Staging/*.patch  # to enable the
checkbox
git am ../wine-staging/patches/uxtheme-CloseThemeClass/*.patch  # prereq from
definition
git am ../wine-staging/patches/uxtheme-GTK_Theming/*.patch
./configure
make -j

it does not build, but it turns out you can make it build by adding
-fshort-wchar to GCC flags in dlls/uxtheme/Makefile.in, and despite spamming a
lot of Gtk-CRITICAL messages it works just fine (if this change is adopted, I
believe the correct patch to get this change would be the one reverting MSCVRT
support).

Another solution would be not to disable MSVCRT for uxtheme, and shift some
code to a "host call gate" DLL, enabling calling subroutines from host ABI .so
libraries (e.g. libgtk-3.so.0), but I did not explore it.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.