[Bug 50460] MDAC/ODBC applications installed by 'winetricks mdac28' don't work since Wine 5.0 ('winetricks' MDAC verbs no longer set 'odbccp32.dll' override to 'native,builtin')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50460

Anastasius Focht <focht at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Some MDAC/ODBC applications |MDAC/ODBC applications
                   |installed by 'winetricks    |installed by 'winetricks
                   |mdac28' don't work          |mdac28' don't work since
                   |('odbccp32.dll' needs       |Wine 5.0 ('winetricks' MDAC
                   |'native,builtin' override   |verbs no longer set
                   |setting in 'winetricks'     |'odbccp32.dll' override to
                   |MDAC verbs)                 |'native,builtin')
    Regression SHA1|45ea03c8a70240e2081ddc87b28 |
                   |65861bb853c2f               |
           Keywords|regression                  |
            Version|4.11                        |5.0

--- Comment #6 from Anastasius Focht <focht at gmx.net> ---
Hello Alexandre,

--- quote ---
Why would this make a difference? Builtin has never worked AFAICT.
--- quote ---

the regression commit was indeed incorrect. I got things mixed up with default
DllMain (and later call through _DllMainCRTStartup) implementations. Builtin
'odbccp32' doesn't provide an own 'DllMain' implementation hence
DLL_WINE_PREATTACH case is not handled.

The only regression would have been if Pierre claimed it worked with Wine < 0.9
- before the builtin 'odbccp32' was introduced
(https://source.winehq.org/git/wine.git/commitdiff/b5c63ed4918eac5dbb2a412c892df9897684ab66).
I doubt that Pierre runs a Wine from early 2000s.

I found the relevant 'winetricks' issue, explaining the behaviour with
different Wine 4.x and 5.x versions:
https://github.com/Winetricks/winetricks/issues/1448

Alistair wrote:

--- quote ---
I've been working on this a quite some time and there isnt a bug associated
with it. This is the commit makes it no longer required.
https://source.winehq.org/git/wine.git/?a=commit;h=8f0057699e141a90f7ed4bb00b14aafe5753b6b9
--- quote ---

Starting with Wine 5.0, 'winetricks' no longer sets a native override:

https://github.com/Winetricks/winetricks/commit/bf2ae6222d26b9048855cff87e8f172a4d4d2b98

While adding 'DllMain' with DLL_WINE_PREATTACH handler is a solution it's not
deemed justified anymore according to Alistair's comment.

The question now is what this bug should be about. Implementing the missing
functionality to make the GUI tools from native MDAC work certainly requires
some effort.

My proposal would be to close this one as 'WONTFIX' - mainly for documentation
- and create new tickets about the missing functionality to make the UI tools
to play nice with builtin.

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.