[Bug 16876] Multiple Microsoft component/prerequisite installers hang in basic UI mode due to incorrect PropertySheet 'Finish' return value for modal sheets (WIC, PowerShell, XPSEPSC)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=16876

--- Comment #18 from Anastasius Focht <focht at gmx.net> ---
Hello folks,

revisiting, obviously still present.

Wine source:

https://source.winehq.org/git/wine.git/blob/9bc3a9f78bf5e6a09d4e9811f645def4a477f3d0:/dlls/comctl32/propsheet.c#l1654

--- snip ---
1654
/******************************************************************************
1655  *            PROPSHEET_Finish
1656  */
1657 static BOOL PROPSHEET_Finish(HWND hwndDlg)
1658 {
1659   PSHNOTIFY psn;
1660   HWND hwndPage;
1661   LRESULT msgResult = 0;
1662   PropSheetInfo* psInfo = GetPropW(hwndDlg, PropSheetInfoStr);
1663 
1664   TRACE("active_page %d\n", psInfo->active_page);
1665   if (psInfo->active_page < 0)
1666      return FALSE;
1667 
1668   psn.hdr.code     = PSN_WIZFINISH;
1669   psn.hdr.hwndFrom = hwndDlg;
1670   psn.hdr.idFrom   = 0;
1671   psn.lParam       = 0;
1672 
1673   hwndPage = psInfo->proppage[psInfo->active_page].hwndPage;
1674 
1675   msgResult = SendMessageW(hwndPage, WM_NOTIFY, 0, (LPARAM) &psn);
1676 
1677   TRACE("msg result %ld\n", msgResult);
1678 
1679   if (msgResult != 0)
1680     return FALSE;
1681 
1682   if (psInfo->result == 0)
1683       psInfo->result = IDOK;
1684   if (psInfo->isModeless)
1685     psInfo->activeValid = FALSE;
1686   else
1687     psInfo->ended = TRUE;
1688 
1689   return TRUE;
1690 }
--- snip ---

$ wine --version
wine-6.0-rc5-25-g9bc3a9f78bf

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.