[Bug 50556] Wine-Gecko debug channel 'gecko' doesn't work since Wine 5.0-rc1 / Wine-Gecko 2.47.1 update (win32 API 'SetEnvironmentVariable' has no effect on CRT 'getenv')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50556

Jacek Caban <jacek at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jacek at codeweavers.com

--- Comment #1 from Jacek Caban <jacek at codeweavers.com> ---
Good catch, thanks for the report. I think that the right place is to change
_PR_InitLog and relevant code in Wine Gecko to use GetEnvironmentVariable
instead of getenv. I will look at that.

All pre-2.47.2 versions of Wine Gecko are linked to msvcrt.dll. Current
versions link to msvcrt.dll or ucrtbase.dll, depending on the toolchain config
(this release allowed using more toolchains, including UCRT-based llvm-mingw).
Official builds use UCRT for 2.47.2.

I think that the bug always existed, but it happened to usually work before
migration to PE started. Wine itself didn't load msvcrt.dll, so it was loaded
by Gecko after mshtml.dll had a chance to set the variable (unless other
application modules pulled it already). I didn't test it, but if I'm right:

- it got "broken" when iexplore.exe and later mshtml.dll and others started
linking to msvcrt.dll
- it got "fixed" by changing Wine builtin components to use UCRT (DLLs first,
programs like iexplore later)
- it got "broken" again by Gecko 2.47.2 release, which moved to Gecko UCRT as
well

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.