[Bug 51465] EVE Online launcher crashes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51465

--- Comment #25 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to algebro from comment #24)
> > "use_msvcrt" is meant here as in contrast to glibc. As far as that naming is
> > concerned, ucrtbase is another version of msvcrt (specifically version 140).
> 
> Ah thanks, that makes sense! I think this patch might also be required, but
> still testing:
> 
> ---
>  tools/winegcc/winegcc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c
> index 8c1e0d088ac..a8235834ed1 100644
> --- a/tools/winegcc/winegcc.c
> +++ b/tools/winegcc/winegcc.c
> @@ -1267,7 +1267,7 @@ static void build(struct options* opts)
>                  if (strncmp( output_name, "msvcr", 5 ) &&
>                      strncmp( output_name, "ucrt", 4 ) &&
>                      strcmp( output_name, "crtdll.dll" ))
> -                    add_library(opts, lib_dirs, files, "ucrtbase");
> +                    add_library(opts, lib_dirs, files, "msvcrt");
>              }
>              else strarray_add(files, strmake("-a%s", crt_lib));
>          }
> -- 
> 2.32.0

It's not required; it actually specifies the default for any libraries compiled
with winegcc, but we are already specifying the CRT library explicitly via
makedep (even for modules currently compiled with ucrtbase). I think it makes
sense for winelib software to use ucrtbase by default, in which case we don't
want the above hunk.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.