[Bug 50603] WiX Toolset v3.9 installer crashes when loading update feed XML

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50603

Damjan Jovanovic <damjan.jov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damjan.jov at gmail.com

--- Comment #1 from Damjan Jovanovic <damjan.jov at gmail.com> ---
If I just take that last msxml function call before the crash:

---snip---
0110:trace:msxml:domelem_next_node (0x7dd51190)->(0: 0x31f698)
---snip---

and I patch that function to return S_FALSE if the nextNode is NULL:

---snip---
+    if (*nextNode == NULL) return S_FALSE;
     return S_OK;
 }
---snip---

the crash is avoided, and the installer proceeds to asking to install .NET 4.

It can't be that simple, can it?

(Note I used dotnet48 here, as Wine-Mono dies from another error (something
about font metrics?). With corefonts Wine-Mono gets further, but still crashes
elsewhere before opening that installation dialog with various options.)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.