[Bug 50778] TortoiseMerge closes before showing a window

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50778

Louis Lenders <xerox.xerox2000x at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |download
                URL|                            |https://osdn.net/projects/t
                   |                            |ortoisesvn/storage/1.14.1/A
                   |                            |pplication/TortoiseSVN-1.14
                   |                            |.1.29085-x64-svn-1.14.1.msi
                   |                            |/
     Ever confirmed|0                           |1
                 CC|                            |xerox.xerox2000x at gmail.com

--- Comment #1 from Louis Lenders <xerox.xerox2000x at gmail.com> ---
Confirming

Looks like caused by uiribbon.dll being a complete stub. Stupid hacks below
allow me to get a (responding) window up, don`t know if it`s further
functional.

Maybe Fabian could have a look at this, to improve the two functions to a kind
of semi-stubs to get this app running

Bug is some kind of meta-bug for this:
 https://bugs.winehq.org/show_bug.cgi?id=43669 

sha1sum TortoiseSVN-1.14.1.29085-x64-svn-1.14.1.msi 
078c6f91a2b9c4990b753c5e5c48668934e86509 
TortoiseSVN-1.14.1.29085-x64-svn-1.14.1.msi


diff --git a/dlls/uiribbon/uiribbon.c b/dlls/uiribbon/uiribbon.c
index 18cb4870f9a..a7898d2e40b 100644
--- a/dlls/uiribbon/uiribbon.c
+++ b/dlls/uiribbon/uiribbon.c
@@ -80,7 +80,7 @@ static HRESULT WINAPI
UIRibbonFrameworkImpl_Initialize(IUIFramework *iface, HWND
 {
     FIXME("(%p, %p): stub!\n", frameWnd, application);

-    return E_NOTIMPL;
+    return 0;
 }

 static HRESULT WINAPI UIRibbonFrameworkImpl_Destroy(IUIFramework *iface)
@@ -94,7 +94,7 @@ static HRESULT WINAPI
UIRibbonFrameworkImpl_LoadUI(IUIFramework *iface, HINSTANC
 {
     FIXME("(%p, %s): stub!\n", instance, debugstr_w(resourceName));

-    return E_NOTIMPL;
+    return 0;
 }

 static HRESULT WINAPI UIRibbonFrameworkImpl_GetView(IUIFramework *iface,
UINT32 viewId, REFIID riid, void **ppv)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.