[Bug 31609] TestLauncher says a required DLL is missing, but the test runs fine without TestLauncher

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31609

François Gouget <fgouget at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |feeea5ba4825a98aac577bf24b1
                   |                            |76697a22bd8cc
         Resolution|---                         |FIXED

--- Comment #8 from François Gouget <fgouget at codeweavers.com> ---
This patch drops the AllImportedDllsPresent() function and all the related
code. Instead it detects the Windows critical error dialog. This allows
TestLauncher to also deal with missing entry points, missing ordinals, and
missing indirect dependencies (when a dll used by the test depends on another
dll that is missing).

commit feeea5ba4825a98aac577bf24b176697a22bd8cc
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Mar 15 19:15:39 2021 +0100

    testbot/TestLauncher: Fix the detection of test executable dependencies.

    Detect the critical error dialog that pops up when the test executable
    depends on a missing dll or entry point.
    This improves the diagnostic messages and avoids long timeouts.

    Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=31609
    Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32216
    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.