[Bug 51748] NIK Dfine2 crashes/hangs (worked before)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51748

--- Comment #6 from Paul Gofman <pgofman at codeweavers.com> ---
So it is adding a query writer stub interface triggered the use of
unimplemented stuff but its improving the query reader's _GetEnumerator stub
which helps? Strange but why not.

I think it is Esme to decide but I don't see anything wrong in returning a stub
string enumerator there.

The suggestions from reading the patch:
- string_enumerator_Next(): should not it set '*num_returned' to 0? I guess
such a stub should behave like the complete implementation for the case of no
strings in enumeration;
- maybe check for memory allocation failure in string_enumerator_create() and
return an E_OUTOFMEMORY accordingly;
- 'string_enumerator_create(void **ppv)': I think it is better to just return
IEnumString ** directly instead of 'void **'.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.